-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RP for plugin-tee-verifiable-log #1369
Open
gene-zhan
wants to merge
11
commits into
elizaOS:develop
Choose a base branch
from
artela-network:ai16zPR/tee-verifiable-log-api-from-develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: RP for plugin-tee-verifiable-log #1369
gene-zhan
wants to merge
11
commits into
elizaOS:develop
from
artela-network:ai16zPR/tee-verifiable-log-api-from-develop
+1,250
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2024
shakkernerd
changed the title
RP for plugin-tee-verifiable-log
feat: RP for plugin-tee-verifiable-log
Dec 23, 2024
odilitime
previously approved these changes
Dec 23, 2024
fix conflict
@odilitime @shakkernerd Could you please help resolve the code conflicts? I’ve already submitted the code several times, but I noticed that the conflicts and the file changes display different content, and I’m not sure how to handle it. |
Hi @gene-zhan alright, I will look into it. |
@shakkernerd Thank you. By the way, is there anything else I need to update or adjust in this pull request to get it merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Add a verifiable log plugin to enable Eliza to sign verifiable logs and provide an interactive query interface. So external parties can query the verifiable logs and verify Eliza's execution process through signature validation.
Risks
Low
Background
What does this PR do?
Eliza running in a TEE (Trusted Execution Environment) is verifiable, ensuring that the AI agent operates strictly according to the code.
However, further development is needed for external parties to verify what Eliza specifically did: external parties should be able to access Eliza's operation logs, and Eliza must use a key pair derived from the TEE to sign these logs. This enables the logs to be verified as authentically originating from Eliza within the TEE.
For example, in the case of an Eliza AI agent running a Twitter client, it could be verified which tweets were posted by Eliza and which were directly posted by a human manually operating the Twitter account.
Future: Based on this plugin, other clients and plugins can generate verifiable logs that need to be authenticated externally. We can further develop a verifiable terminal for TEE Eliza to display signed, verifiable logs in real-time.
What kind of change is this?
Documentation changes needed?
Yes, we will add documentation for using this plugin, including the guide on how other plugins can import it and generate verifiable logs.
Testing
Where should a reviewer start?
Understand the existing
plugin-tee
plugin-tee
and use its key derivation interface.Understand what
plugin-tee-verifiable-log
doesWhat is not included in this PR
plugin-tee-verifiable-log
and modifies the direct client.plugin-tee-verifiable-log
in existing clients: Enhancements for existing clients to generate verifiable logs that need external validation. For instance, modifying the Twitter client to depend onplugin-tee-verifiable-log
and produce logs that are worthy of external verification.Detailed testing steps
It have completed the integration tests and can run the
pnpm test
file in the test directory.